https://bugzilla.redhat.com/show_bug.cgi?id=1441816 --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Several notes: * Is there any reason to package the git snapshot? Wouldn't it be easier to go with the latest official release (0.3.2). I am using some older version (0.3.1) of your diorite package and I don't observe any issues. Also, since there is not provided any API/ABI stability guarantee, I'd say that it would be better to package just stable versions and the projects using this library should always explicitly specify the diorite version. * I don't think the "Release" field is formatted according to the guidelines [1]. I should be 0.1.20171104git%{shortcommit0} IMO. * What is the reason to use the bundled version of "waf"? We have waf package in Fedora, is it possible to use it instead? * Wouldn't be %setup sufficient in place of %autosetup? * As far as I understand, the "waf configure" is using pkgconfig to check the proper configuration. Wouldn't it be more appropriate to use virtual provides such as "BuildRequires: pkgconfig(gtk+-3.0)" * I don't think you need vala-devel, since you are not going to extend Vala. The only thing you need is actually Vala compiler which is provided by "vala" package, but it might be better to "BuildRequires: %{_bindir}/valac" instead. * Since the application is later build using GCC, you should consider to add "BuildRequires: gcc" [2]. * There appears to be tests suite. Is there a chance to execute it during build? * The license should be just "BSD" shouldn't it? I can't see any code licensed under LGPLv3+ and LGPLv2+. * There is no license file included. Could you please query upstream to add one [3]? [1] https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots [2] https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx