https://bugzilla.redhat.com/show_bug.cgi?id=1428913 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- fedora-review marked two things to fix in the must section, but I disagree that they are strict requirements so I'm passing the review. Suggestions to improve the spec file: [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx