Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nspluginwrapper - A compatibility layer for Mozilla/Firefox plugins Alias: nspluginwrapper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236521 ------- Additional Comments From stransky@xxxxxxxxxx 2007-07-27 07:57 EST ------- (In reply to comment #87) > additional questions: > - why statements like > %if "%{target_bits}" == "64" > export CFLAGS="-g -m64 -DDEBUG" > %else > export CFLAGS="-g -m32 -DDEBUG" > %endif Fixed in package above (nspluginwrapper-0.9.91.4-8.fc7.src.rpm) > - this statement isn't needed > %if "%{target_bits}" == "64" > export LDFLAGS="-m64 -L%{libdir64}" > %else > export LDFLAGS="-m32 -L%{libdir32}" > %endif It has to be there (this package uses his own ./configure & make) > -in %install section I've found > ln -s %{pkglibdir}/npwrapper.so $RPM_BUILD_ROOT/%{plugindir}/npwrapper.so > isn't it typo? (ln -s $RPM_BUILD_ROOT/%{pkglibdir}/npwrapper.so > $RPM_BUILD_ROOT/%{plugindir}/npwrapper.so) It's correct, you can check a binary package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review