https://bugzilla.redhat.com/show_bug.cgi?id=1441071 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: a5b8345757ca4f2b9335f5be14e93ebbb502865233a755bf53bc7156deec001b) is original. Ok. Summary verified from lib/Mock/Config.pm. Ok. Description is Ok. License verified from README and lib/Mock/Config.pm. Ok. No XS code, noarch BuildArch is Ok. Test::Pod 1.22 not used. Ok. Test::Pod::Coverage 1.08 not used. Ok. Pod::Coverage 0.18 not used. Ok. All test pass. Ok. $ rpmlint perl-Mock-Config.spec ../SRPMS/perl-Mock-Config-0.03-1.fc27.src.rpm ../RPMS/noarch/perl-Mock-Config-0.03-1.fc27.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Mock-Config-0.03-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Apr 11 15:15 /usr/share/doc/perl-Mock-Config -rw-r--r-- 1 root root 283 Apr 18 2016 /usr/share/doc/perl-Mock-Config/Changes -rw-r--r-- 1 root root 3637 Apr 18 2016 /usr/share/doc/perl-Mock-Config/README -rw-r--r-- 1 root root 2825 Apr 11 15:15 /usr/share/man/man3/Mock::Config.3pm.gz drwxr-xr-x 2 root root 0 Apr 11 15:15 /usr/share/perl5/vendor_perl/Mock -rw-r--r-- 1 root root 4709 Apr 18 2016 /usr/share/perl5/vendor_perl/Mock/Config.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Mock-Config-0.03-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(:VERSION) >= 5.6.0 1 perl(Config) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(warnings)' (lib/Mock/Config.pm:63). $ rpm -q --provides -p ../RPMS/noarch/perl-Mock-Config-0.03-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Mock::Config) = 0.03 1 perl-Mock-Config = 0.03-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Mock-Config-0.03-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=18926692). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx