https://bugzilla.redhat.com/show_bug.cgi?id=1440780 --- Comment #3 from Luboš Uhliarik <luhliari@xxxxxxxxxx> --- Thank you Remi, for your review. (In reply to Remi Collet from comment #1) > Quick notes. > > Error: Transaction check error: > file /usr/lib64/httpd/modules/mod_http2.so from install of > mod_http2-1.10.0-1.fc25.remi.x86_64 conflicts with file from package > httpd-2.4.25-1.fc25.x86_64 > > What is the need of this package if already provided by httpd ? Joe decided, that it would be better to have mod_http2 as separate module, since upstream is producing releases more often, than httpd releases. I knew about this problem, so I will will add Requires tag, which will require httpd >= than version, which will not contain mod_http2 (I have to remove it from httpd). > > - compatibility macro for htpd 2.2 are obviously unneeded (IIRC only > _httpd_mmn is need at buildtime) - you are right, I forgot to remove them from SPEC file. Fixed. > > - latest version is 1.10.1 - they released this version yesterday, after I made this package... Fixed. > > - LICENSE file must be packaged - they are missing LICENCE file in release tar.gz. Reported to upstream. https://github.com/icing/mod_h2/issues/136 > > - why is there versioned .so, obviously not wanted - fixed > > - why no LoadModule directive for mod_proxy_httpd2 ? - fixed > > - %changelog need to be fixed (with your name/address) - fixed You can download updated SPEC and SRPM here: Spec URL: https://luhliarik.fedorapeople.org/mod_http2.spec SRPM URL: https://luhliarik.fedorapeople.org/mod_http2-1.10.1-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx