Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdegames3 - KDE 3 games not ported to KDE 4 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248647 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-07-27 05:26 EST ------- Here we go, starting directly wiht a full review. MUST ---- 0 rpmlint output is: W: kdegames3 macro-in-%changelog _bindir This mist be fixed, always use %% in the changelog W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/ktron/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/kpoker/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/ksmiletris/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/ksokoban/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/kenolaba/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/kfouleggs/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/atlantik/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/kasteroids/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/ksnake/common ../common W: kdegames3 dangling-relative-symlink /usr/share/doc/HTML/en/klickety/common ../common These are normal for KDE apps. E: kdegames3 file-in-usr-marked-as-conffile /usr/share/config.kcfg/kasteroids.kcfg W: kdegames3 conffile-without-noreplace-flag /usr/share/config.kcfg/kasteroids.kcfg E: kdegames3 file-in-usr-marked-as-conffile /usr/share/config.kcfg/kfouleggs.kcfg W: kdegames3 conffile-without-noreplace-flag /usr/share/config.kcfg/kfouleggs.kcfg E: kdegames3 file-in-usr-marked-as-conffile /usr/share/config.kcfg/ksnake.kcfg W: kdegames3 conffile-without-noreplace-flag /usr/share/config.kcfg/ksnake.kcfg E: kdegames3 file-in-usr-marked-as-conffile /usr/share/config.kcfg/ktron.kcfg W: kdegames3 conffile-without-noreplace-flag /usr/share/config.kcfg/ktron.kcfg Either these are config files and should be moved to /etc/kde and be made %config(noreplace) or they are merely defaults / template files and should not be %config at all. kdebase puts files under /usr/share/config.kcfg and doesn't mark them %config. E: kdegames3 invalid-desktopfile /usr/share/applications/kde/kpoker.desktop This is caused by the faulty / obsolete "Miniicon=kpoker" line, remove this and all is fine. * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * locales handled properly * Shared libraries, ldconfig run as required * Not relocatable 0 Package owns or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * .desktop file as required MUST _really_ FIX ----------------- * this one is so important I just invented a new catagory for it :) Currently the specfile contains: %if 0%{?rhel} > 1 %define patch_name -patched %else %define patch_name %{nil} %endif And: Source: ftp://ftp.kde.org/pub/kde/stable/%{version}/src/kdegames-%{version}%{patch_name}.tar.bz2 However there is no kdegames-3.5.7-patch.tar.bz2 on the kde site, so RHEL uses a different tarbal, which doesn't come from upstream, which leads to the following: 1) Why? 2) Please do this with patches and or binary (small tarbal) overlays, since its fine for Fedora, there isn't a legal problem so no reason to use a modified tarbal 3) If you must use a modified tarbal, then a) Add a comment above the Source tag explaining in detail what was changed b) make the Source tag just the filename instead of a non existing URL MUST fix -------- * Various rpmlint errors, see above * Add Requires: hicolor-icon-theme for /usr/share/icons/hicolor/*/* dir ownership * unowned directory /usr/share/config.kcfg (own, or maybe better file a bug against kdelibs3 that it should own it). Should fix ---------- * This would seem like a good moment to prune the changelog a bit * Are the debug final and cvs defines + conditional code still needed? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review