[Bug 1411962] Review Request: golang-github-milochristiansen-lua - A Lua 5.3 VM and compiler written in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1411962



--- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
1) The new release provides a few new go subpackages:

> Provides:      golang(%{import_path}/supermeta) = %{version}-%{release}
> Provides:      golang(%{import_path}/testhelp) = %{version}-%{release}

Please add them to the -devel subpackage's Provides: section.


2) Additionally, add

> %gotest %{import_path}/supermeta

after the

> %gotest %{import_path}

line, since that subpackage also has tests.


3) Please add the

> %global commit          cbee393f691f87139e9f21525610767e85ae0e33
> %global shortcommit     %(c=%{commit}; echo ${c:0:7})

and maybe

> # commit cbee393f691f87139e9f21525610767e85ae0e33 == version 1.1.1

to the .spec header (after the import_path definition, where you removed it
from in the first place). This information is used by gofed to track versions
of golang packages across all of fedora.


Otherwise, the package looks good now!


PS: I usually re-run gofed when I bump my golang packages to a new version to
make sure I catch issues like [1] and [2]. Maybe that helps you in the future!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]