https://bugzilla.redhat.com/show_bug.cgi?id=1397261 --- Comment #25 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #24) > This is not an acceptable response to any of my feedback. What has been > going on in the past is not a factor my review of this now, as I want this > package to *work*. That said, I will take a look at the other ones, but I > still want you to fix *this one*. You have not indicated any definite issue with the package actually *working*: > - Please split AppStream metainfo file out into a separate source file and > install it that way The guidelines allow for either: https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation > - Also, please check on whether metainfo file is complete. Meaning, does it > have enough information for GNOME Software or Plasma Discover to use the > information to be able to select the codecs when queried by applications? I > suspect not. You suspect not based on what? > > make install DESTDIR=$RPM_BUILD_ROOT > > Please change to "%make_install" The guidelines consider these equally valid: https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
