Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Emesene - Emesene is an MSN Messenger client written in python and GTK Alias: Emesene https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238379 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Package Review |ORBit ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-27 02:30 EST ------- OK, now that mybashburn is getting close to being done, I'll take a look at this. It builds fine and rpmlint finds nothing to complain about. I can't compare the sources with upstream, because this is a checkout from a subversion tree. It's OK to package snapshots like this, but you need to provide instructions on creating the tarball you are packaging. See http://fedoraproject.org/wiki/Packaging/SourceURL You're using the versioning scheme for post-release snapshots, but according to the upstream URL it seems to me that version 1.0 has not been released. Thus you'd have to use a version-release of something like 1.0-0.2.20070711svn, so that when 1.0 is finally released you can go to just 1.0-1. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines (look for the "Pre-Release packages" section). I would remove "It's" from the summary, as I can't think of any summaries that begin with pronouns. This isn't a big deal, however. Your call to desktop-file-install is a little weird; why is it indented like that? /usr/share/emesene is unowned; change %{_datadir}/%{name}/* in %files to %{_datadir}/%{name} to fix it. ? Can't compare source with upstream. X package does not meet naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. ? latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: emesene = 1.0-2.20070711svn.fc8 = /bin/sh dbus-python gtk2 pygtk2 python * %check is not present; no test suite upstream. I installed and ran it; it seemed to start OK but I have no MSN account to actually log in with. X does not own /usr/share/emesene * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (desktop database update) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review