https://bugzilla.redhat.com/show_bug.cgi?id=1433657 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx --- Comment #2 from Till Maas <opensource@xxxxxxxxx> --- AFAICS the RPM macro pkgver is defined but not used, please consider removing it. Also the README file in the tarball contains the license information, therefore it might be a good idea to add it as %license, however the actual license is missing in the tarball (see https://github.com/jeroennijhof/vncpwd/issues/1) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx