[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #4 from Mattia Verga <mattia.verga@xxxxxxxx> ---
===== MUST items =====
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 84 files have unknown
     license. Detailed output of licensecheck in /home/rpmbuild/1437937
     -libva-utils/licensecheck.txt

It seems that many files are licensed as BSD, there's also a BSD LICENSE file
under test/gtest. I think it's better to add a double license in .spec, or
maybe this should be clarified with upstream.

BSD (3 clause)
--------------
libva-utils-1.8.0/decode/loadjpeg.c
libva-utils-1.8.0/decode/tinyjpeg-internal.h
libva-utils-1.8.0/decode/tinyjpeg.c
libva-utils-1.8.0/decode/tinyjpeg.h
libva-utils-1.8.0/test/gtest/LICENSE
libva-utils-1.8.0/test/gtest/include/gtest/gtest-death-test.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-message.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-printers.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-spi.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-test-part.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest-typed-test.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest.h
libva-utils-1.8.0/test/gtest/include/gtest/gtest_prod.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest-port.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest-printers.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/custom/gtest.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-death-test-internal.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-filepath.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-internal.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-linked_ptr.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-param-util.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-port-arch.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-port.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-string.h
libva-utils-1.8.0/test/gtest/include/gtest/internal/gtest-tuple.h.pump
libva-utils-1.8.0/test/gtest/src/gtest-all.cc
libva-utils-1.8.0/test/gtest/src/gtest-death-test.cc
libva-utils-1.8.0/test/gtest/src/gtest-filepath.cc
libva-utils-1.8.0/test/gtest/src/gtest-internal-inl.h
libva-utils-1.8.0/test/gtest/src/gtest-port.cc
libva-utils-1.8.0/test/gtest/src/gtest-printers.cc
libva-utils-1.8.0/test/gtest/src/gtest-test-part.cc
libva-utils-1.8.0/test/gtest/src/gtest-typed-test.cc
libva-utils-1.8.0/test/gtest/src/gtest.cc
libva-utils-1.8.0/test/gtest/src/gtest_main.cc


===== EXTRA items =====
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: libva-utils-1.8.0/configure.ac:99

Maybe this should be reported upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]