https://bugzilla.redhat.com/show_bug.cgi?id=1368855 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #9 from Michael Scherer <misc@xxxxxxxx> --- >>> %doc %{_datadir}/doc/%{name} >>Drop this one; it's no longer needed or allowed. > I do not understand your request - please explain why the %files and %doc should be dropped. That's just the line for the directory that should dropped, since that's done by rpm already. > True. Not used for the release packing. Source0 used when packing from git > directly (in case of patches preventing build on fedora). I think it would be better to remove it, since this will requires to upload the file to the lookaside cache for no reason. > Changed to GPLv3+ due to its viral nature, although majority of the package is > meant to be licensed LGPL. I think you need to list all licenses: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx