https://bugzilla.redhat.com/show_bug.cgi?id=1431426 Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST --- Comment #7 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> --- (In reply to Julien Enselme from comment #2) > > The mock build fails. > > I missed a build requires, sorry. This should be fixed: > > Spec URL: http://dl.jujens.eu/SPECS/python-dbfread.spec > SRPM URL: > http://dl.jujens.eu/SRPMS/python-dbfread-2.0.7-2.git300b2d7.fc25.src.rpm Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-dbfread , python3-dbfread , python-dbfread-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-dbfread-2.0.7-2.git300b2d7.fc24.noarch.rpm python3-dbfread-2.0.7-2.git300b2d7.fc24.noarch.rpm python-dbfread-doc-2.0.7-2.git300b2d7.fc24.noarch.rpm python-dbfread-2.0.7-2.git300b2d7.fc24.src.rpm python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/dbf2sqlite /usr/bin/env python python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/dbfinfo.py /usr/bin/env python python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/files/make_example_files.py /usr/bin/env python2 Rpmlint (installed packages) ---------------------------- python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/dbf2sqlite /usr/bin/env python python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/files/make_example_files.py /usr/bin/env python2 python-dbfread-doc.noarch: E: wrong-script-interpreter /usr/share/doc/python-dbfread-doc/examples/dbfinfo.py /usr/bin/env python The Rpmlint errors can be taken care of by fixing the shebangs. Package is APPROVED. Please fix the shebangs before submitting the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx