[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
It works now, thanks. Suggestions for improvements:

1) Since you are packaging version 1.0, you should set
> Version: 1.0
> Release: 1%{?dist}
and correct it the changelog entry too (1.0-1).

2) You can drop the empty %if-endif blocks at lines 94, 86 and 68.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]