https://bugzilla.redhat.com/show_bug.cgi?id=1427085 --- Comment #4 from Raphael Groner <projects.rg@xxxxxxxx> --- Sorry for the very long delay here. I had a lot of daily job work to do. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= MUST fix: - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in plantumlqeditor See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database - Can not completely validate GPLv3+ of source files due to missing headers, please poke upstream about those: plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/assistantxmlreader.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/filecache.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/main.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/mainwindow.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/preferencesdialog.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/previewwidget.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/recentdocuments.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/textedit.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/utils.cpp plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/assistantxmlreader.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/filecache.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/mainwindow.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/preferencesdialog.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/previewwidget.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/recentdocuments.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/settingsconstants.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/textedit.h plantumlqeditor-edb5f633b3544a35ee9f8fd841f86373bc3dc5ce/utils.h (additional tests files can be ignored, they don't get into binary package) - Add a license breakdown, see also above about guessable with GPLv3+ files. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios - Remove duplication of folders ownership, see note below. https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package - Note correct release string in changelog, see rpmling warning. https://fedoraproject.org/wiki/Package_Versioning_Examples#Complex_versioning_examples - Unbundle qtsingleapplication, it's available as a separate package. See README.qtsingleapplication. SHOULD fix: - May want to use latest commit for the package. As of now: 7a96d90 - Please include README.mime into %doc, it contains useful information about mime integration. Even better would be if package can configure that. - Please move appstream-util validate-relax from %install into %check. - May be worth to run tests of dedicated subfolder in %check. - Please use 'cp -p' to preserve timestamps also for icons and translations. - Please drop useless /usr/lib/.build-id file, see rpmlint warnings. - Suggestion: Better use clean patches instead of the sed commands to properly adjust configuration. https://fedoraproject.org/wiki/Packaging:Guidelines#Fedora-specific_.28or_rejected_upstream.29_patches - In %build, pushd/popd is preferred over '(cd build-dir; %cmake …)' and more common in packages I've seen so far, especially to have locations get logged. https://www.eriwen.com/bash/pushd-and-popd/ - May optimize %files and drop all %dir lines and just include complete folders by optionally adding a slash ('/') at the end. For instance, actually just one line needed instead: -%dir %{_datadir}/%{name} -%{_datadir}/%{name}/assistant.xml -%dir %{_datadir}/%{name}/icons -%{_datadir}/%{name}/icons/* +%{_datadir}/%{name}/ http://tldp.org/HOWTO/RPM-HOWTO/build.html#FILES ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 137 files have unknown license. Detailed output of licensecheck in /home/builder /fedora-review/1427085-plantumlqeditor/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora- logos), /usr/share/appdata(filesystem), /usr/share/applications(filesystem), /usr/share/mime/packages(shared- mime-info) [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in plantumlqeditor [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: update-mime-database is invoked in %post and %postun if package stores mime configuration in /usr/share/mime/packages. Note: mimeinfo files in: plantumlqeditor See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo => False positive, propably due to assembled scriplet. [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in plantumlqeditor-debuginfo => Ignore. debuginfo is auto-generated. [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: plantumlqeditor-1.2-5.20170306gitedb5f63.fc27.x86_64.rpm plantumlqeditor-debuginfo-1.2-5.20170306gitedb5f63.fc27.x86_64.rpm plantumlqeditor-1.2-5.20170306gitedb5f63.fc27.src.rpm plantumlqeditor.x86_64: W: incoherent-version-in-changelog 1.2-5.20170227git95b9e7c ['1.2-5.20170306gitedb5f63.fc27', '1.2-5.20170306gitedb5f63'] plantumlqeditor.x86_64: W: only-non-binary-in-usr-lib plantumlqeditor.x86_64: W: hidden-file-or-dir /usr/lib/.build-id plantumlqeditor.x86_64: W: hidden-file-or-dir /usr/lib/.build-id plantumlqeditor.x86_64: W: no-manual-page-for-binary plantumlqeditor plantumlqeditor.src: W: spelling-error %description -l en_US plantuml -> plantain 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: plantumlqeditor-debuginfo-1.2-5.20170306gitedb5f63.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory plantumlqeditor.x86_64: W: incoherent-version-in-changelog 1.2-5.20170227git95b9e7c ['1.2-5.20170306gitedb5f63.fc27', '1.2-5.20170306gitedb5f63'] plantumlqeditor.x86_64: W: only-non-binary-in-usr-lib plantumlqeditor.x86_64: W: hidden-file-or-dir /usr/lib/.build-id plantumlqeditor.x86_64: W: hidden-file-or-dir /usr/lib/.build-id plantumlqeditor.x86_64: W: no-manual-page-for-binary plantumlqeditor 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- plantumlqeditor-debuginfo (rpmlib, GLIBC filtered): plantumlqeditor (rpmlib, GLIBC filtered): /bin/sh graphviz hicolor-icon-theme java libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) plantuml rtld(GNU_HASH) shared-mime-info Provides -------- plantumlqeditor-debuginfo: plantumlqeditor-debuginfo plantumlqeditor-debuginfo(x86-64) plantumlqeditor: appdata() appdata(plantumlqeditor.appdata.xml) application() application(plantumlqeditor.desktop) mimehandler(application/x-plantumlqeditor) plantumlqeditor plantumlqeditor(x86-64) Source checksums ---------------- https://github.com/borco/plantumlqeditor/archive/edb5f633b3544a35ee9f8fd841f86373bc3dc5ce.tar.gz#/plantumlqeditor-1.2-20170306gitedb5f63.tar.gz : CHECKSUM(SHA256) this package : 6050c0aae7b2a33c406d30ec7cd49ab1d3ba76dcaf2c60615cfc176af0204182 CHECKSUM(SHA256) upstream package : 6050c0aae7b2a33c406d30ec7cd49ab1d3ba76dcaf2c60615cfc176af0204182 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1427085 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx