Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: numactl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226207 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora orion@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From orion@xxxxxxxxxxxxx 2007-07-26 14:45 EST ------- Problems: rpmlint: W: numactl summary-not-capitalized library for tuning for Non Uniform Memory Access machines W: numactl-devel no-dependency-on numactl E: numactl-devel useless-explicit-provides numactl-devel This should fix: --- numactl.spec 12 Jan 2007 14:37:41 -0000 1.39 +++ numactl.spec 26 Jul 2007 18:36:20 -0000 @@ -1,5 +1,5 @@ Name: numactl -Summary: library for tuning for Non Uniform Memory Access machines +Summary: Library for tuning for Non Uniform Memory Access machines Version: 0.9.8 Release: 2%{dist} License: LGPL/GPL @@ -21,7 +21,7 @@ %package devel Summary: Development package for building Applications that use numa Group: System Environment/Libraries -Provides: numactl-devel +Requires: %{name} = %{version}-%{release} %description devel Provides development headers for numa library calls Please consider the missing Requires a bug that should be fixed in FC-6 and up - it breaks builds. Buildroot needs fixing: The recommended values for the BuildRoot tag are (in descending order of preference) : %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root Need to add to %files: %doc README you might also add CHANGES Good: - package meets naming guidelines - license (LGPL/GPL) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no .la files - post/postun ldconfig ok Suggestion: Why not: %prep -%setup -q -c -a 0 -%patch1 -%patch2 -p1 +%setup -q +%patch1 -p1 +%patch2 -p2 %build -cd numactl-%{version} make CFLAGS="$RPM_OPT_FLAGS -I. -fPIC" %install @@ -44,7 +43,6 @@ mkdir -p $RPM_BUILD_ROOT%{_mandir}/man5 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man8 -cd numactl-%{version} make prefix=$RPM_BUILD_ROOT/usr libdir=$RPM_BUILD_ROOT/%{_libdir} install %clean -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review