https://bugzilla.redhat.com/show_bug.cgi?id=1401302 --- Comment #17 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Few comments from me, but none is blocker: > BuildRequires: python3-sip This is not needed, because there is already: > BuildRequires: python3-sip-devel It's guaranteed by guidelines that it will bring-in the python3-sip package automatically. > %if "%{_libdir}" == "/usr/lib64" > sed -i 's|DESTINATION lib|DESTINATION lib64|g' CMakeLists.txt > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR lib64|g' CMakeLists.txt > %endif Maybe simpler way: sed -i 's|DESTINATION lib|DESTINATION %{_lib}|g' CMakeLists.txt sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR %{_lib}|g' But maybe better is to patch the cmake files (and persuade upstream) to incorporate support for -DLIB_SUFFIX=64, in this way it will work out of the box. Is the patch needed? Couldn't be the same behavior achieved by e.g.: cmake -DCMAKE_SKIP_RPATH:BOOL=ON -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx