[Bug 1435920] Review Request: python-j1m.sphinxautointerface - Sphinx extension for documenting zope.interface interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1435920



--- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> ---
Thanks for the review, Antonio.

(In reply to Antonio Trande from comment #1)
> - License file is not installed

There is no license file to install.  Upstream did not include one.  I will ask
about that, but since upstream for this package considers itself a temporary
fork of yet another upstream, I don't know if the developer will be willing to
add one.

> - setup.py does not run any test

Hmm, you're right.  Should I just remove %check for now?

> - Please, remove egg-info files from upstream
>   http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Egg_Packages

That rule applies to egg packages containing compiled bytecode and possibly
compiled extensions.  The egg directory in this package contains only egg
metadata, which does not have to be removed because it is regenerated during
the build.  Also, see this thread:

https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/FOG5APDRQVNXR5ZOZZSVDNZVN4WURKG4/#FOG5APDRQVNXR5ZOZZSVDNZVN4WURKG4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]