https://bugzilla.redhat.com/show_bug.cgi?id=1421245 --- Comment #17 from Haïkel Guémar <karlthered@xxxxxxxxx> --- 1. licensing seems to be LGPLv2.1 according README so short identifier should LGPLv2 (or GPLv3 if it's an alternative provided by upstream) 2. license file is not included in package 3. gcc-c++ and make are included in buildroot, so no need to include them. 4. for your rpmlint error, likely a false positive https://github.com/rpm-software-management/rpmlint/issues/73 5. include README.md using %doc in main package 6. I'm not sure to understand why not using %cmake macros, you can add missing parameters in the end. At least set build type to debug and shared libs parameters. 7. I suspect that googletest/googlemock bundled are only used in tests that are not shipped. Is it possible to build/run tests using system copies? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx