[Bug 1428974] Review Request: rgbds - A development package for Game Boy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428974



--- Comment #14 from Sanqui (David Labský) <dlabsky@xxxxxxxxxx> ---
Spec URL: https://sanqui.net/etc/fedora/rgbds-0.2.5-2/rgbds.spec
SRPM URL:
https://sanqui.net/etc/fedora/rgbds-0.2.5-2/rgbds-0.2.5-1.fc25.src.rpm
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18607028

>- Aesthetically, I'd add an empty line between %changelog entries.

I have added newlines between changelog entries.

>- I see a test directory on upstream GitHub. Is there a testsuite you can run?
Sadly, the tests are extremely primitive[1] and currently failing[2]. 
Hopefully in the future.

[1] https://github.com/rednex/rgbds/blob/v0.2.4/test/asm/test.sh
[2]
https://paste.fedoraproject.org/paste/wHpYP9kkBOVVXDNpfoL2gV5M1UNdIGYhyRLivL9gydE=

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]