[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1377631



--- Comment #12 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> ---
(In reply to Andrew Toskin from comment #10)
> Anyway, more review:
> 
> Line 17 of the spec: Source1 tag is missing a colon.
> 
> 
> You're still including the schemas in the extension's own directory. You
> don't need this. Spec file line 50:
> 
>   mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas
> 
> Lines 56 and 57:
> 
>   install -Dp -m 0644 schemas/gschemas.compiled \
>      
> %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/gschemas.
> compiled
> 
> 
> Everything else looks good to me, except for the pending issues on GitHub.

I have made your suggestion, but I get the following error message when running
the Preferences dialog of gnome-tweak-tool or gnome-shell-extension-prefs:

"GLib.FileError: Failed to open file
'/usr/share/gnome-shell/extensions/netspeed@xxxxxxxxxxxxxxxxxx/schemas/gschemas.compiled':
open() failed: No such file or directory

Stack trace:
  @/usr/share/gnome-shell/extensions/netspeed@xxxxxxxxxxxxxxxxxx/prefs.js:31
 
Application<._getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:74
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178
 
Application<._selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:89
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178
 
Application<._extensionFound/<@resource:///org/gnome/shell/extensionPrefs/main.js:202
  main@resource:///org/gnome/shell/extensionPrefs/main.js:377
  @<main>:1"

upstream ticket: https://github.com/hedayaty/NetSpeed/issues/56

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]