https://bugzilla.redhat.com/show_bug.cgi?id=1397261 --- Comment #15 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #8) > Initial review notes: > > - libmad is now in Fedora, so that module can be enabled Per comments above, it's been removed upstream. > - Please split AppStream metainfo file out into a separate source file and > install it that way This is exactly how it is done in the other gstreamer1-plugins-* packages. > - Also, please check on whether metainfo file is complete. Meaning, does it > have enough information for GNOME Software or Plasma Discover to use the > information to be able to select the codecs when queried by applications? I > suspect not. Then please confirm this and file bugs against the other gstreamer1-plugins-* packages, because this is *exactly* what they are doing. > > make %{?_smp_mflags} > > Please change to "%make_build" Ditto. > > make install DESTDIR=$RPM_BUILD_ROOT > > Please change to "%make_install" Ditto. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx