Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gdhcpd - GTK+ administration tool for DHCPD https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249505 jochen@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review?, needinfo? ------- Additional Comments From jochen@xxxxxxxxxxxxxxx 2007-07-26 11:55 EST ------- Good: + Package meets naming guidelines + SPACE file name matches with packabe base name + Package has consitant macoro usage + License is GPL + License tag matches with License in the tar ball + Package contains a verbatim copy of the license text + SPEC is in English + SPEC is legible + Tar ball matches with upstream (md5sum: a59be9812f7cf39c1401aa68b601ca68) + Package has correct buildroot + Package contains no sub packages + BuildRequies doesn't redundant + Local build works properly + Local install and uninstall works fine + Local start of the application works fine + application has a proper menu entry + Package has proper %defattr and file permissions + Package has a connect %clean section + Buildroot will be cleaned properly on start of the %install section + File list doesn't contains duplicates files + File list doesn't contains file or directories owned be other packages + %doc section is small + File in %doc section doesn't affect runtime + Rpmlint is quite on source package + Rpmlint is quite on binary package + Rpmlint is quite on debuginfo package + Mock works fine on Devel(x86_65, ppp64, ppc) + Bad: - I will prefer gettext-devel over gettext as a BR -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review