[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1429804



--- Comment #2 from Nathan Scott <nathans@xxxxxxxxxx> ---
Hi gil,

(In reply to gil cattaneo from comment #1)
> These ifile are not admitted in Fedora. Please, remove
> 
> BuildRequires: maven-shade-plugin

Symbol shading is required for parfait-agent since it produces a javaagent jar
which can be loaded at runtime into arbitrary Java applications.  The exact
same approach is used by byteman, another javaagent which is already in Fedora,
so I don't think there's an issue here.

> Please, remove also:
> "Requires: java-headless >= 1.8" already listed as requirement by our java
> tools by default
> "%dir %{_javadir}/parfait" already listed in 

Done.

> "Group: ..." not MORE necessary

Done.

> Please, change "%global disable_dropwizard 1" with "%bcond_with metrics". and
> %if %{with metrics}
> and
> %if %{without metrics}

Done.

I've uploaded revised packages here - https://bintray.com/pcp/f25/parfait

SPEC:  https://bintray.com/pcp/f25/download_file?file_path=parfait.spec
SRPM: 
https://bintray.com/pcp/f25/download_file?file_path=parfait-0.5.1-3.fc25.src.rpm

cheers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux