https://bugzilla.redhat.com/show_bug.cgi?id=1428926 --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Thanks for the review (In reply to Randy Barlow from comment #1) > Created attachment 1265193 [details] > review.txt > > Suggestions, at your option: > > * You can drop the rm -rf %{buildroot} in the install section. > fedora-review put this in the MUST section, but I disagree so I am > willing to pass as-is. > * You can drop the %defattr statement in the files section. > * You can drop the BuildRoot: line. > * You can delete the %clean section. Yes, I usually clean those during Fedora import (and will be able to totally clean them in my repo in ~1 week \o/) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx