https://bugzilla.redhat.com/show_bug.cgi?id=1428926 --- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Created attachment 1265193 --> https://bugzilla.redhat.com/attachment.cgi?id=1265193&action=edit review.txt Suggestions, at your option: * You can drop the rm -rf %{buildroot} in the install section. fedora-review put this in the MUST section, but I disagree so I am willing to pass as-is. * You can drop the %defattr statement in the files section. * You can drop the BuildRoot: line. * You can delete the %clean section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx