https://bugzilla.redhat.com/show_bug.cgi?id=1434127 --- Comment #1 from Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> --- + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches X License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: 8114ba0144a158d5ad1bdf02e6f43195 v0.4.0 8114ba0144a158d5ad1bdf02e6f43195 srpm/dehydrated-0.4.0.tar.gz + Package needs ExcludeArch + BuildRequires correct X Package has %defattr and permissions on files is good. + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. Fine: dehydrated.src: W: spelling-error %description -l en_US openssl -> slope dehydrated.src: W: spelling-error %description -l en_US subdomains -> sub domains, sub-domains, domains dehydrated.noarch: W: spelling-error %description -l en_US subdomains -> sub domains, sub-domains, domains dehydrated.noarch: W: only-non-binary-in-usr-lib dehydrated.noarch: E: non-standard-executable-perm /etc/dehydrated/hook.sh 750 dehydrated.noarch: E: wrong-script-interpreter /etc/dehydrated/hook.sh /usr/bin/env bash dehydrated.noarch: W: non-ghost-in-run /run/dehydrated dehydrated.noarch: E: non-standard-dir-perm /run/dehydrated 750 dehydrated.noarch: E: wrong-script-interpreter /usr/bin/dehydrated /usr/bin/env bash dehydrated.noarch: E: wrong-script-interpreter /usr/share/doc/dehydrated/examples/hook.sh /usr/bin/env bash dehydrated.noarch: W: no-manual-page-for-binary dehydrated Understandable: dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated 750 dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/accounts 750 dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/archive 750 dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/certs 750 dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/conf.d 750 Possibly wrong: dehydrated.noarch: E: non-readable /etc/dehydrated/conf.d/local.sh 640 dehydrated.noarch: E: non-readable /etc/dehydrated/config 640 dehydrated.noarch: E: non-readable /etc/dehydrated/domains.txt 640 dehydrated.noarch: E: non-readable /etc/dehydrated/hook.sh 750 + final provides and requires are sane: Provides: config(dehydrated) = 0.4.0-4.fc27 dehydrated = 0.4.0-4.fc27 Requires: /bin/sh /usr/bin/env config(dehydrated) = 0.4.0-4.fc27 curl openssl SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. + Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Issues: 1. License file included in package 2. Package has %defattr and permissions on files is good. - Some of the permissions are strange -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx