[Bug 1433767] New: Review Request: ptpython - Python REPL build on top of prompt_toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1433767

            Bug ID: 1433767
           Summary: Review Request: ptpython - Python REPL build on top of
                    prompt_toolkit
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody@xxxxxxxxxxxxxxxxx
          Reporter: carl.george@xxxxxxxxxxxxx
        QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx



Spec URL: https://carlgeorge.fedorapeople.org/ptpython/ptpython.spec
SRPM URL:
https://carlgeorge.fedorapeople.org/ptpython/ptpython-0.36-1.fc25.src.rpm
COPR: https://copr.fedorainfracloud.org/coprs/carlgeorge/ptpython/
Description: Ptpython is an advanced Python REPL built on top of the
prompt_toolkit library.  It features syntax highlighting, multiline editing
(the up arrow works), autocompletion, mouse support, support for color schemes,
support for bracketed paste, both Vi and Emacs key bindings, support for double
width (Chinese) characters, and many other things.
Fedora Account System Username: carlgeorge

I plan to maintain this in both Fedora and EPEL6/7 eventually, but I need to
get python-jedi into EPEL first.  For now just treat this as a Fedora-only
request (f25/f26/master).

$ rpmlint \
> SPECS/ptpython.spec \
> SRPMS/ptpython-0.36-1.fc25.src.rpm \
> RPMS/ptpython2-0.36-1.fc25.noarch.rpm \
> RPMS/ptpython3-0.36-1.fc25.noarch.rpm 
ptpython.src: W: spelling-error %description -l en_US multiline -> multilingual
ptpython.src: W: spelling-error %description -l en_US autocompletion -> auto
completion, auto-completion, completion
ptpython2.noarch: W: spelling-error %description -l en_US Ptpython -> Pt
python, Pt-python, Python
ptpython2.noarch: W: spelling-error %description -l en_US multiline ->
multilingual
ptpython2.noarch: W: spelling-error %description -l en_US autocompletion ->
auto completion, auto-completion, completion
ptpython2.noarch: W: no-manual-page-for-binary ptpython
ptpython2.noarch: W: no-manual-page-for-binary ptpython2
ptpython2.noarch: W: no-manual-page-for-binary ptpython2.7
ptpython2.noarch: W: no-manual-page-for-binary ptipython
ptpython2.noarch: W: no-manual-page-for-binary ptipython2
ptpython2.noarch: W: no-manual-page-for-binary ptipython2.7
ptpython3.noarch: W: spelling-error %description -l en_US Ptpython -> Pt
python, Pt-python, Python
ptpython3.noarch: W: spelling-error %description -l en_US multiline ->
multilingual
ptpython3.noarch: W: spelling-error %description -l en_US autocompletion ->
auto completion, auto-completion, completion
ptpython3.noarch: W: no-manual-page-for-binary ptpython3
ptpython3.noarch: W: no-manual-page-for-binary ptpython3.5
ptpython3.noarch: W: no-manual-page-for-binary ptipython3
ptpython3.noarch: W: no-manual-page-for-binary ptipython3.5
3 packages and 1 specfiles checked; 0 errors, 18 warnings.

I believe the spelling warnings are false positives.  Upstream doesn't provide
manpages.  For reference, two other Python REPLs in Fedora (ipython and
bpython) don't have man pages either.

I also want to address my thought process behind the package naming.  Since
this is primarily used as a CLI tool, not as an importable module, I didn't
think the naming it "python{,2,3}-ptpython" was the best choice.  Instead, I
went with a naming scheme that felt a bit more natural.

SRPM: ptpython
RPM: ptpython2 (provides python2-ptpython, python-ptpython, and ptpython)
RPM: ptpython3 (provides python3-ptpython)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]