[Bug 1411054] Review Request: nodejs-needle - The leanest and most handsome HTTP client in the Nodelands

[bugzilla@xxxxxxxxxx]

https://bugzilla.redhat.com/show_bug.cgi?id=1411054



--- Comment #2 from Tom Hughes <tom@xxxxxxxxxx> ---
There's a format error in the first changelog entry (a missing hyphen).

There's a newer version (1.5.2) available.

There's no reason not to run the tests - you just need to require openssl and
then generate a certificate. Instructions are in the readme but an enhanced
version that sets the subject to stop it prompting is:

mkdir -p test/keys
openssl genrsa -out test/keys/ssl.key 2048
openssl req -new -key test/keys/ssl.key -x509 -subj /CN=test@xxxxxxxxxxx -days
999 -out test/keys/ssl.cert

After that the tests run though I am seeing a few failures:

  1) with output option and a 200 response for a binary file uses a
writableStream:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

  2) with output option and a 200 response for a binary file writes a file:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

  3) with output option and a 200 response for a binary file file size equals
response length:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

  4) with output option and a 200 response for a binary file file is equal to
original buffer:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

  5) with output option and a 200 response for a binary file returns the data
in resp.body too:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

  6) with output option and a 200 response for a binary file closes the file
descriptor:
     Uncaught TypeError: pixel.binarySlice is not a function
      at handler (test/output_spec.js:188:27)
      at Server.<anonymous> (test/output_spec.js:35:7)
      at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
      at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx