https://bugzilla.redhat.com/show_bug.cgi?id=1377631 mgansser@xxxxxxxx <mgansser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@xxxxxxxxx --- Comment #7 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Andrew Toskin from comment #5) > I don't know where Leigh came up with incrementing the version from 3.16 to > 3.17. As Sam said, according to the extension's metadata.json file, the > version is either 25 or 26, depending on whether you're getting it from the > extensions website, or from GitHub... And since the spec uses commit tags on > GitHub as the Source0, I suppose it's a "pre-release" of version 26 (even > though 26 has been released elsewhere). > > Other issues: > > [x]: glib-compile-schemas is run in %postun and %posttrans if package has > *.gschema.xml files. > > You correctly compile the gschema in the system glib directory, so > you don't need to include the precompiled copy (or even the > directory) at: > %{builddir}/%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/ > > You can remove it at the end of the %install section, probably > just before %find_lang would be best. done > > [?]: The spec file handles locales properly. > > Looks to me like the locale files are all in the right place, but > when I changed my system language to French and German, the settings > widget was still all in English. > > This is *probably* a problem upstream, since the version > installed from the EGO site doesn't seem to translate either. > > https://github.com/hedayaty/NetSpeed/issues/55 I have also determined, but still no solution. Upstream is dead ? > [!]: Requires correct, justified where necessary. > > Should require GNOME Shell 3.10+, according to metadata.json's > list of compatible versions of GNOME. > > For any GNOME Shell extension, you should also list > gnome-shell-extension-common as a dependency. done > > [x]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > There's an open issue about this: > https://github.com/hedayaty/NetSpeed/issues/50 added link to ticket. > > The patch which adds newer versions of GNOME to the compatibility list > should hopefully be taken care of upstream: > > https://github.com/hedayaty/NetSpeed/issues/42 done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-netspeed.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-netspeed-3.17-0.4.20160806git16a25ec.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx