[Bug 1421304] Review Request: python-aiohttp-cors - CORS ( Cross Origin Resource Sharing) support for aiohttp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421304

Yves L'ECUYER <yves.lecuyer.linfedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yves.lecuyer.linfedora@oran
                   |                            |ge.fr



--- Comment #2 from Yves L'ECUYER <yves.lecuyer.linfedora@xxxxxxxxx> ---
Thanks for the prototype given in your  first comment.
Because I need this immediately too for GNS3 1.5.3.

Get rid of this warning is very easy, just change the description:
rpmlint suggest Asuncion in place of asyncio, because asyncio is not in US
dictionnary !!!
Personnaly I replaced , your python3-aiohttp-1.0.5-3.fc25.src.rpmoriginal
Description by:
=======
aiohttp_cors library implements Cross Origin Resource Sharing (CORS) support
for aiohttp asynchronous-input-output-powered HTTP server.
=========

And because it protests also about a macro in comment (test are disabled)
I Just replaced:
# %{__python3} setup.py test

BY
# ${__python3} setup.py test 
# where $ above must be replaced by %  if you want to re-enable it!!!


AND NOW :
[root@encelade SPECS]# rpmbuild -bs python-aiohttp-cors.spec
Wrote: /root/rpmbuild/SRPMS/python-aiohttp-cors-0.5.0-1.fc25.src.rpm
[root@encelade SPECS]# rpmlint
/root/rpmbuild/SRPMS/python-aiohttp-cors-0.5.0-1.fc25.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

But I have added too 
Requires:      python3-aiohttp >= 1.1
otherwise, in fedora 25 because the last update is :
python3-aiohttp-1.0.5-3.fc25
There is a silent installatiopython3-aiohttp-1.0.5-3.fc25.src.rpmn by dnf, but
we got python error when gns3 service is launched, claiming that it requires
python3-aiohttp >= 1.1 !!

CONSEQUENTLY
python3-aiohttp- must be updated in fedora 25 repository.
I tried to use python-aiohttp-1.3.3-1.fc26.src.rpm recompiled for fc25,
but there is too much dependency with other python libraries not available for
fc25.
so python3-aiohttp-1.1.6 is just the ultimate choice to satisfy
python-aiohttp-cors-0.5.0-1.fc25 dependencies, and not requiring other python
updates
the src.rpm :python3-aiohttp-1.0.5-3.fc25.src.rpm is just usable as it is, just
changing the version, in 1.1.6 -1, and the link for source0 inside the
specfile, is still usable to get the tarball
I got it with:
===========
srcname=aiohttp
version=1.1.6
wget  
https://github.com/KeepSafe/aiohttp/archive/v${version}/${srcname}-${version}.tar.gz
==========
Just an ultimate remark
[root@encelade SPECS]# rpmbuild -bs  python-aiohttp.spec
Wrote: /root/rpmbuild/SRPMS/python-aiohttp-1.1.6-1.fc25.src.rpm
[root@encelade SPECS]# rpmlint
/root/rpmbuild/SRPMS/python-aiohttp-1.1.6-1.fc25.src.rpm
python-aiohttp.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-aiohttp.src: W: spelling-error %description -l en_US asyncio -> Asuncion
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

SO THE SPEC FILE of python3-aiohttp-1.0.5-3.fc25.src.rpm , in standard fedora
update repository was already producing the same US English spelling error, for
the same word as in your first comment ! and nobody care about that  ??

So why not to ignore the warning too, in  python-aiohttp-cors ???

===========
So I have already built my gns3-gui and gns3-server from the 1.5.2 src package
and replacing 1.5.2 -3  by 1.5.3 -1 in specfile

and the corresponding tarball, downloaded from the link provided in the
specfile
with
=========================
name=gns3-gui
version=1.5.3
wget 
https://github.com/GNS3/${name}/archive/v${version}/${name}-${version}.tar.gz

name=gns3-server
wget
https://github.com/GNS3/${name}/archive/v${version}/${name}-${version}.tar.gz
========================

And all is built correctly, and installed without any warning

AND FINALLY
[root@encelade fedora25_packages]# systemctl start gns3
[root@encelade fedora25_packages]# systemctl status gns3
● gns3.service - GNS3 server
   Loaded: loaded (/usr/lib/systemd/system/gns3.service; enabled; vendor
preset: disabled)
   Active: active (running) since Fri 2017-03-17 23:08:30 CET; 6s ago
 Main PID: 19828 (gns3server)
    Tasks: 1 (limit: 4915)
   CGroup: /system.slice/gns3.service
           └─19828 /usr/bin/python3 /usr/bin/gns3server

Mar 17 23:08:30 encelade systemd[1]: Started GNS3 server.
[root@encelade fedora25_packages]#

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]