[Bug 1421183] Review Request: ntetris - simple cli tetris game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421183

jiri vanek <jvanek@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #5 from jiri vanek <jvanek@xxxxxxxxxx> ---
(In reply to Michal Vala from comment #4)
> up, same links. just specfile diff:
> https://github.com/sparkoo/NTetris/commit/
> 632ed12eef9141b46662b8dc508dfc4ed2de6d68.diff
> 
> [!]: Uses parallel make %{?_smp_mflags} macro.
> - Aplication is very trivial, imho not worthy of foxing. Michal?
> should be already built in parallel. see log
> https://kojipkgs.fedoraproject.org//work/tasks/8991/18428991/build.log -> "+
> /usr/bin/make -O -j16 PREFIX=/usr"

Oh right! the macro did its job..
> 
> - Michal, do you wont to add CZ metadata to spec?
> done
> 
Thanx!

> - Michal ,do you ind to start scratch on rawhide to see also ppc?
> done 
> rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18429020
> f24: https://koji.fedoraproject.org/koji/taskinfo?taskID=18428982
> f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18428989

Thanx!
> 
> - no tests:(
> no tests for now, sorry. may add later when I refactor the app.

Sound like never to me, but sure...

Pacakge is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]