[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1433121



--- Comment #2 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
> Is there any special reason for not running the tests?

They were failing for me due to a broken dependency. It needs to be fixed by
either fixing the dependency or updating this package to a newer one. This
package will get eventually updated and the test gets fixed.

> The content of the examples is only used by the test cases. It is not a test
case itself, but shouldn't it be moved to the unit-test subpackage AND to %doc
on the -devel package?

I will move the code there once the tests are running properly.

> Upstream provides versions (v1.1 tag is available on the same commit packaged).
You should update the Version and Release tags accordingly [1]. Refer to [2] 
if you need to package post 1.1 commits.

Good point. The current spec generator does not care about the version as it is
hard to retrieve it from the github. I will update the spec file.

Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]