[Bug 1432975] Review Request: freerdp1.2 - Compatibility version of the FreeRDP client libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1432975

Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
1.
[...]
%ifarch x86_64
    -DWITH_SSE2=ON \
%else
    -DWITH_SSE2=OFF \
%endif
%ifarch armv7hl
    -DARM_FP_ABI=hard \
    -DWITH_NEON=OFF \
%endif
%ifarch armv7hnl
    -DARM_FP_ABI=hard \
    -DWITH_NEON=ON \
%endif
%ifarch armv5tel armv6l armv7l
    -DARM_FP_ABI=soft \
    -DWITH_NEON=OFF \
%endif
%ifarch aarch64
    -DWITH_SSE2=OFF \
%endif
[...]

The last %ifarch aarch64 is redundant, as that case is already handled by
%ifarch x86_64 ... %else above.

2. Redundant BuildRequires:
gstreamer1-devel (pulled in by gstreamer1-plugins-base-devel)
zlib-devel (pulled in by cups-devel and gstreamer1-plugins-base-devel)
libX11-devel (pulled in by libXcursor-devel, libXdamage-devel, libXext-devel,
libXrandr-devel and libXv-devel)
libXext-devel (pulled in by libXi-devel, libXinerama-devel, libXrandr-devel and
libXv-devel)

No other issues, package is APPROVED.

You can fix the above when importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]