Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lzma - lzma compression tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248301 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-25 13:40 EST ------- Some comments as one of sponsor members: * If -devel subpackage is licensed under LGPL, the corresponding documents should be installed as a %doc of -devel subpackage (i.e. add LICENSE.LIB to %doc of -devel subpackage). * Add ChangeLog to %doc * Usually the dependency against main or subpackage should be version-release specific. i.e. main package should have: Requires: %{name}-libs = %{version}-%{release} and -devel package should have: Requires: %{name} = %{version}-%{release} * Provides: %{name}-devel = ... on -devel subpackage is not needed * Explain why -devel package *must* have Provides: lzmadec-devel = %{version}-%{release} (I suggest to remove this) * Please use the following to keep timestamps on header files and man pages. ---------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="%{_install} -p" ----------------------------------------------------- * We now recommend %defattr(-,root,root,-) * and %defattr(0644,root,root,-755) on -devel package is not needed. * You define %{src_version} and it seems that it can be used also for source tarball name. * Files under %{_mandir} is automatically tagged as %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review