https://bugzilla.redhat.com/show_bug.cgi?id=1427341 --- Comment #18 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- OK, let me have a look. 1) Summary. You don't have to set the %{sum} macro, you can write a summary into the Summary field and then use %{summary} in the subpackages. 2) Description. I don't think an URL belongs there. Just use it as the URL instead of the github one. 3) Since this is Python 2 only, I think you should have python2-gamera subpackage instead of python-gamera package. Once python- will mean python3, you would have trouble this way. 4) The summary of devel subpackage should definitely not bee the same as the main package. 5) "Devel gamera package." is not verbose enough as description. "Development package for gamera. Allows you to develop your apps on top of the gamera framework." might be a little bit better. 6) I'd add some whitespace to %install so the lines that do one thing are together 7) Add comment to the shebang removal so it's obvious what's happening there and WHY 8) I don't think the devel subpackage is a header only library per se, so the -static provide here is bogus. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx