https://bugzilla.redhat.com/show_bug.cgi?id=1432104 --- Comment #7 from Benjamin Lefoul <benjamin.lefoul@xxxxxxxx> --- (In reply to Richard Shaw from comment #6) > (In reply to Benjamin Lefoul from comment #5) > > > > rsync-bpc.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/rsync_bpc > > This is often a false positive, any comment? > > I'm not really sure but I ran rpmlint on the rsync package and it gets the > same error so I assume if it's actually a problem then once it's fixed in > the rsync package it can be fixed here. Fair enough. > > > > [!]: %check is present and all tests pass. > > I tried running "make check" but it fails, I don't think Craig updated the > test to work with his fork. OK. This is not not a MUST item, but it would be nice to know if the fork breaks the tests. If you want to ask him, can you CC the ML (I'm reading backuppc-users@xxxxxxxxxxxxxxxxxxxxx)? Apart from that this is good for approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx