https://bugzilla.redhat.com/show_bug.cgi?id=1411962 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Initial comments: 1) Please update your .spec and .src.rpm for the newest upstream version (1.1.0). 2) Please drop the leading "A" from the Summary line. 3) Please change the target file name for your sources, for example you can use: "Source0: https://%{provider_prefix}/archive/v%{version}/%{project}-%{repo}-%{version}.tar.gz"; to avoid name collisions with "official" lua package sources (otherwise your sources will be "lua-1.1.0.tar.gz", which looks like official lua sources ...). 4) Are you sure it's a good idea to provide the "vendored" go library? If not, just remove the "Provides: golang(%{import_path}/vendor/sliceutil) = %{version}-%{release}". 5) You can remove the empty %if-endif block at line 77. 6) You can use "%setup -q -n %{repo}-%{version}" in %prep. 7) Please correct the GOPATH definition on line 136, the Godeps directory isn't in the sources, so this seems to be there by accident. 8) Please drop the %{dist} tag from the changelog entry, it doesn't belong there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx