https://bugzilla.redhat.com/show_bug.cgi?id=1411961 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Initial comments: 1) You should use Release: 0.1.git%{shortcommit}%{?dist} (including the leading zero), since this is a pre-release snapshot, not a post-release-snapshot. 2) The zlib license has only been confirmed for another repo, but not for this one. Please make sure that the same license applies for this code too. 3) You might want to use a different target file name four your download, for example: "Source0: https://%{provider_prefix}/archive/%{commit}/%{project}-%{repo}-%{shortcommit}.tar.gz"; (so _including_ the "project" prefix; no other changes in the .spec file needed), to prevent confusion / conflicts with other package's sources. 4) You can remove the empty %if-%endif blocks at lines 70 and 89. 5) Please remove / adapt the GOPATH definition on line 144, the Godeps directory isn't present in the sources - is this a leftover from an earler version? 6) Please ask upstream to include a COPYING file in this repository too (and link the upstream issue in the .spec file or in a comment here, to document that you did your "homework". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx