https://bugzilla.redhat.com/show_bug.cgi?id=1432214 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |admiller@xxxxxxxxxx Flags| |needinfo?(admiller@redhat.c | |om) --- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Some thoughts after a first pass: * It's pretty weird for an RPM to put static css/html/js into /var, and I think it might be a violation of FHS since this is not state data, though I'm not sure. These files should go into /usr/share I believe. It sounds like this app might also write to this same folder, which makes things a little weird. Can the app handle its static files being in /usr/share while it's variable data is in /var/lib? * Also, I think it might be more typical to use /var/lib/ instead of /var. * Wherever the static content goes, the spec file also needs to own the directory. Right now, /var/reg-server is unowned. * Is it possible to avoid the bundled dependencies? If so, we should "make every effort". If not, I think we need to publicly contact upstream about a path to supporting system libraries as documented at: https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries Also, I found the Go packaging draft guidelines to read confusingly about this, but it sounds like they prefer packages not to bundle: https://fedoraproject.org/wiki/PackagingDrafts/Go#Dependencies * If we do need to keep the bundled deps, I think we might need the license field to list the licenses of them all. Based on fedora-review's license check, I suggest: License: ASL 2.0 and BSD and MIT Optional/Suggestions/Questions: * You can set Source0 to a GitHub URL despite there not being a release. For example: https://github.com/jessfraz/reg/archive/94d0af58c1d2afaa5541fe48729002888f370456/reg-0.2.0.tar.gz * Is it a typo in the unit file that there's a =- instead of just = after EnvironmentFile? * The --debug env var is uncommented, but it sounds like it's meant to be commented. * You should use %global instead of %define on the docroot variable. * You can remove the . from the Summary to get rid of a lint warning. * Mixed usage of spaces and tabs can kill another lint warning. <rant> * Go is a huge mess. You can't see any go code without constant "if error… if error… if error…" everywhere. And the bundling and practice of not making releases and just using git commits of your dependencies creates a huge nope of a language. It's almost as bad as JavaScript! </rant> -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx