[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Initial comments:

1) You can remove the empty %if-%endif block in the -unit-test-devel package
section (at lines 77-80).

2) You are simply disabling one of the tests - have you reported the failing
test upstream? Maybe this can be fixed upstream so you can run all tests for
this package.

3) What does the GOPATH definition in line 136 mean? I don't see the Godeps
directory in the source tarball. Is this there by mistake?

4) You can use the following Source URL to avoid ugly hackery:
https://%{provider_prefix}/archive/v%{version}/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]