https://bugzilla.redhat.com/show_bug.cgi?id=1327979 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #25 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- I have neglected mathjax terribly. Great the packaged version is still OK. + package name is OK (I still think python-jupyter-notebook would be better, like I said in comment #c2, but it's a bike shedding issue) + latest version (5.0.0b2 is tagged, but it seems better to target the stable release) + %check is present and passes + BR/R/P are correct, afaict + modern python packaging template is used + %python_provide is present + builds and installs OK + seems to run OK + various stuff has been unbundled, we can unbundle more later (jquery, etc) + license is acceptable (3-clause BSD) + license is specified correctly rpmlint: python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/MathJax /usr/share/javascript/mathjax python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/backbone /usr/share/javascript/backbone python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/font-awesome/fonts /usr/share/fonts/fontawesome python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/marked/lib /usr/share/javascript/marked python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/moment /usr/share/javascript/moment python2-notebook.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/notebook/static/components/underscore /usr/share/javascript/underscore python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/MathJax /usr/share/javascript/mathjax python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/backbone /usr/share/javascript/backbone python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/font-awesome/fonts /usr/share/fonts/fontawesome python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/marked/lib /usr/share/javascript/marked python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/moment /usr/share/javascript/moment python3-notebook.noarch: W: dangling-symlink /usr/lib/python3.6/site-packages/notebook/static/components/underscore /usr/share/javascript/underscore Bogus, those symlinks all point to unbundled deps. python3-notebook.noarch: W: no-manual-page-for-binary jupyter-nbextension python3-notebook.noarch: W: no-manual-page-for-binary jupyter-notebook python3-notebook.noarch: W: no-manual-page-for-binary jupyter-serverextension Yeah, would be nice to add those, at least with some pointers to html docs... python-notebook-doc.noarch: W: summary-not-capitalized C notebook documentation "notebook" is the name, so it's OK. 3 packages and 0 specfiles checked; 0 errors, 16 warnings. Package is APPROVED. Two nitpicks: there's a blank line at start of %description for python2-notebook subpackage. The %description for python3-notebook should use %_description. OK, let's get this pushed out and iron out any integration issues in rawhide/F26. I this is more likely to work than trying to get everything perfect in bugzilla attachments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx