https://bugzilla.redhat.com/show_bug.cgi?id=1428861 --- Comment #4 from michal.simon@xxxxxxx --- Some initial comments: 1. rpmlint output is not clean: Rpmlint ------- Checking: xrdhttpvoms-0.2.4-1.el7.centos.x86_64.rpm xrdhttpvoms-0.2.4-1.el7.centos.src.rpm xrdhttpvoms.x86_64: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: W: incoherent-version-in-changelog 0.2.0-2 ['0.2.4-1.el7.centos', '0.2.4-1.centos'] xrdhttpvoms.x86_64: E: library-without-ldconfig-postin /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: E: library-without-ldconfig-postun /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libXrdHttpVOMS-4.so xrdhttpvoms.src: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.src: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 1) xrdhttpvoms.src: W: invalid-url Source0: xrdhttpvoms-0.2.4.tar.gz Rpmlint (installed packages) ---------------------------- xrdhttpvoms.x86_64: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: W: incoherent-version-in-changelog 0.2.0-2 ['0.2.4-1.el7.centos', '0.2.4-1.centos'] xrdhttpvoms.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 /lib64/libm.so.6 xrdhttpvoms.x86_64: E: library-without-ldconfig-postin /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: E: library-without-ldconfig-postun /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libXrdHttpVOMS-4.so xrdhttpvoms-debuginfo.x86_64: W: only-non-binary-in-usr-lib For sure we need to fix the errors: - summary should not exceed 79 characters - post and postun are obligatory: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig It would be also good to fix the warnings: - incoherent-version-in-changelog - devel-file-in-non-devel-package (either add a devel package or don't install .so) - unused-direct-shlib-dependency - and the trivial staff 2. License file LICENSE is marked as %doc instead of %license 3. CMake build type should be 'RelWithDebInfo' 4. The 'rm -rf %{buildroot}' statement in %install and the %clean section are unnecessary (unless you are planing to release for EPEL5) 5. The %defattr should only be used when setting a non-default value, here it is unnecessary (unless you are planing to release for EPEL5) 6. The Buildroot tag should not be used (unless you are planing to release for EPEL5) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx