https://bugzilla.redhat.com/show_bug.cgi?id=1427341 --- Comment #11 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- As this package is quite complex I will post my findings so far and after we get these out of the way, we can proceed with the rest. All the BuildRequires are fine. You should remove the comment after %install about the python2 and python3 install, since the package is python2 and only uses the %py2_install macro The desktop file installation should happen after the %py2_install. Also what is the reason for this line? chmod 755 %{buildroot}/%{python2_sitearch}/%{srcname}/gendoc.py Same for: %doc %attr(644,-,-) README And: %defattr(644,root,root,755) The devel subpackage should have a Requires tag for the main package. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package This comment is not required: # For noarch packages: sitelib Also while it is good to keep some level of abstraction when specifying the directories and binaries at the files section, I would recommend to be more specific about some things, since it helps while working with the package. e.g. Remove: '%{python2_sitearch}/%{srcname}*' Add '%{python2_sitearch}/%{srcname}' and '%{python2_sitearch}/%{srcname}-%{version}-py?.?.egg-info' Also the %{_includedir}/python2.7/%{srcname}/ should be changed to %{_includedir}/python%{python2_version}/%{srcname}/ Now as for the binaries. The package provides two of them for which it would be good practice to list them individually at the respective files sections, so basically instead of %{_bindir}/*, use %{_bindir}/gamera_gui and %{_bindir}/gamera_post_install.py However what is the purpose of gamera_post_install.py binary? I kinda think that it might be required to be included at the devel subpackage. Also the package ships a lot of .so libraries so you should read the respective section at the packaging guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx