[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
No need to specify "BuildArch:      noarch" more than once.

Those loops ("for file in leather/*.py; do...") are not necessary, sed takes
multiple arguments.

I like minimalism, I'd also replace "pushd docs, popd" with a '-C docs'
argument to make...

I also think the description could be a bit more down-to-earth. I *do* think
the text you have is funny, but OTOH, it doesn't say too much about the package
;)
E.g. the stuff from the documentation, "produces scale-invariant SVGs", etc, is
pretty useful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]