[Bug 1125360] Review Request: perl-Swim - See What I Mean is a plain text markup language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1125360

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Swim-0.1.46-1.fc27.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Encode)
      1 perl(FindBin)
      1 perl(Getopt::Long)
      1 perl(HTML::Escape)
      1 perl(IPC::Run)
      1 perl(Pegex) >= 0.41
      1 perl(Pegex::Base)
      1 perl(Pegex::Grammar)
      1 perl(Pegex::Parser)
      1 perl(Pegex::Tree)
      1 perl(Swim)
      1 perl(Swim::Command)
      1 perl(Swim::Grammar)
      1 perl(Swim::Markup)
      1 perl(Swim::Util)
      1 perl(Text::Autoformat)
      1 perl(YAML::XS)
      1 perl(base)
      1 perl(constant)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Add 'perl(Hash::Merge)' - lib/Swim/Util.pm:7

$ rpm -qp --provides perl-Swim-0.1.46-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Swim) = 0.1.46
      1 perl(Swim::Byte)
      1 perl(Swim::Command)
      1 perl(Swim::Grammar)
      1 perl(Swim::HTML)
      1 perl(Swim::Markdown)
      1 perl(Swim::Markup)
      1 perl(Swim::Pod)
      1 perl(Swim::Tree)
      1 perl(Swim::Util)
      1 perl-Swim = 0.1.46-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Swim*
perl-Swim.noarch: W: spelling-error %description -l en_US roff -> toff, riff,
off
perl-Swim.noarch: W: no-manual-page-for-binary swim
perl-Swim.src: W: spelling-error %description -l en_US roff -> toff, riff, off
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

Rpmlint is ok

License is ok
NOTE: README and Swim.pod contains as link to license
      http://www.perl.com/perl/misc/Artistic.html
      Please ask upstream to replace it by http://dev.perl.org/licenses/

Please correct 'FIX' issue.

Otherwise package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]