https://bugzilla.redhat.com/show_bug.cgi?id=1420100 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Please add run-requires > - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75 +Requires: perl(IO::Lines) Ok. > FIX: Please add following build-requires: > - coreutils - because 'rm' is used in spec file > - findutils - 'find' is used in spec file > - make - is used in spec file > - perl or %{__perl} - it is used in spec file > - perl(base) - Mail-Transport-3.000/lib/Mail/Transport.pm:12 > - perl(IO::Handle) - Mail-Transport-3.000/Makefile.PL:5 > - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75 > - perl(strict) - modules and tests > - perl(Test::More) - tests > - perl(vars) - modules > - perl(warnings) - modules and tests +BuildRequires: perl +BuildRequires: perl(base) +BuildRequires: perl(IO::Handle) +BuildRequires: perl(IO::Lines) +BuildRequires: perl(strict) +BuildRequires: perl(Test::More) +BuildRequires: perl(vars) +BuildRequires: perl(warnings) +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: make Ok. > FIX: Please remove __requires_exclude of Mail::SpamAssassin, it is not > needed. -#%%global __requires_exclude %%{?__requires_exclude:%%__requires_exclude|}^perl\\(Mail::SpamAssassin[:\\)] Ok. > TODO: It will be better placed %{?perl_default_filter} before %description. Ok. TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. Please consider fixing 'TODO' item. Otherwise package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx