[Bug 1431020] Review Request: perl-Alien-pkgconf - Discover pkgconf and libpkgconf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1431020

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Alien-pkgconf-0.10-1.fc27.x86_64.rpm | sort | uniq -c
      1 libpkgconf-devel(x86-64) = 1.3.0
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(File::ShareDir) >= 1.102
      1 perl(File::Spec)
      1 perl(JSON::PP) >= 2.27400
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Alien-pkgconf-0.10-1.fc27.x86_64.rpm | sort | uniq -c
      1 perl(Alien::pkgconf) = 0.10
      1 perl-Alien-pkgconf = 0.10-1.fc27
      1 perl-Alien-pkgconf(x86-64) = 0.10-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Alien-pkgconf*
perl-Alien-pkgconf.src: W: spelling-error Summary(en_US) libpkgconf
perl-Alien-pkgconf.src: W: spelling-error %description -l en_US libpkgconf
perl-Alien-pkgconf.src: E: specfile-error sh: pkgconf: command not found
perl-Alien-pkgconf.x86_64: W: spelling-error Summary(en_US) libpkgconf
perl-Alien-pkgconf.x86_64: W: spelling-error %description -l en_US libpkgconf
perl-Alien-pkgconf.x86_64: E: no-binary
perl-Alien-pkgconf.x86_64: W: only-non-binary-in-usr-lib
./perl-Alien-pkgconf.spec: E: specfile-error sh: pkgconf: command not found
2 packages and 1 specfiles checked; 3 errors, 5 warnings.

'pkgconf' is listed in BR.
Explanation about full-arch package is in spec file.

Rpmlint is ok

BuildRequires are almost ok
FIX: Please add BR 'perl(File::Copy)': script/system.pl:4                   

Please correct 'FIX' issue.

Otherwise package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]