https://bugzilla.redhat.com/show_bug.cgi?id=1409802 Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dhanesh95@xxxxxxxxxxx --- Comment #1 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> --- (In reply to Julien Enselme from comment #0) > Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec > SRPM URL: > http://dl.jujens.eu/SRPMS/python-leather-0.3.3-1.gite85dd30.fc25.src.rpm > Disclaimer : I'm not a packager yet. So this is an unofficial review. Here's what fedora-review tells me: * Rpmlint output: Rpmlint ------- Checking: python2-leather-0.3.3-1.gite85dd30.fc24.noarch.rpm python3-leather-0.3.3-1.gite85dd30.fc24.noarch.rpm python-leather-doc-0.3.3-1.gite85dd30.fc24.noarch.rpm python-leather-0.3.3-1.gite85dd30.fc24.src.rpm python2-leather.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python2-leather.noarch: W: spelling-error %description -l en_US doesn -> does, does n python3-leather.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python3-leather.noarch: W: spelling-error %description -l en_US doesn -> does, does n python-leather-doc.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python-leather-doc.noarch: W: spelling-error %description -l en_US doesn -> does, does n python-leather-doc.noarch: W: file-not-utf8 /usr/share/doc/python-leather-doc/html/objects.inv python-leather.src: W: spelling-error %description -l en_US isn -> sin, ins, ism python-leather.src: W: spelling-error %description -l en_US doesn -> does, does n 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- python-leather-doc.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python-leather-doc.noarch: W: spelling-error %description -l en_US doesn -> does, does n python-leather-doc.noarch: W: file-not-utf8 /usr/share/doc/python-leather-doc/html/objects.inv python3-leather.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python3-leather.noarch: W: spelling-error %description -l en_US doesn -> does, does n python2-leather.noarch: W: spelling-error %description -l en_US isn -> sin, ins, ism python2-leather.noarch: W: spelling-error %description -l en_US doesn -> does, does n 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Typos. Everything else seems good. fedora-review does throw an issue regarding the license : Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.txt is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text But I think this can be safely ignored. COPYING is already a part of %license. Also, there is no file named license.txt in the source. So I don't see why this is an issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx