https://bugzilla.redhat.com/show_bug.cgi?id=1429226 --- Comment #6 from VincentS <vincent@xxxxxxxxxxxxxxxxxx> --- For me, the package is ok. Package Review ============== REVIEW: + OK - NA X ISSUE + Package meets naming and packaging guidelines. + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches ^^ I'm not sure about license files. I haven't seen information about MIT, GPLv3+ or BSD. + License file included in package + Spec in American English + Spec is legible. + Sources match upstream sha256sum: $ sha256sum 0.9.3.tar.gz rpmbuild/SOURCES/dataagregator-0.9.3.tar.gz 7155278107f56a01bf90b9df7a743744643cfbd59eb726f7629b9a7c44768763 0.9.3.tar.gz 7155278107f56a01bf90b9df7a743744643cfbd59eb726f7629b9a7c44768763 rpmbuild/SOURCES/dataagregator-0.9.3.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. $ rpmls /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.x86_64.rpm -rwxr-xr-x /usr/bin/DataAgregator drwxr-xr-x /usr/share/doc/dataagregator -rw-r--r-- /usr/share/doc/dataagregator/README.md drwxr-xr-x /usr/share/licenses/dataagregator -rw-r--r-- /usr/share/licenses/dataagregator/COPYING + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + Rpmlint output: $ rpmlint rpmbuild/SPECS/dataagregator.spec /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.x86_64.rpm dataagregator.src: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.src: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.x86_64: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: no-manual-page-for-binary DataAgregator 2 packages and 1 specfiles checked; 0 errors, 5 warnings. + final provides and requires are sane. SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) No issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
